Skip to content

refactor setbits #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

refactor setbits #11

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4f4d6bb
Change meaning of `p` argument
isidroas Feb 16, 2025
5a98acf
refactor setbits()
isidroas Jan 20, 2025
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Change meaning of p argument 
Previusly: counted from the right of n

	xxx..xnnnnx..xxx
		 p     0

Now: counted from the left of n (like the book)

	xxx..xnnnnx..xxx
	      p        0
  • Loading branch information
@isidroas
isidroas committed Feb 16, 2025
commit 4f4d6bba86aa386ff93004f387e94a79446cff0f
4 changes: 2 additions & 2 deletions chapter-2-types-operators-expressions/11.setbits.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,8 @@ main()

int setbits(int x, int p, int n, int y)
{
x = x & (~((~(~0 << n)) << p));
y = (y & (~(~0 << n))) << p;
x = x & (~((~(~0 << n)) << (p - n + 1)));
y = (y & (~(~0 << n))) << (p - n + 1);

return x | y;
}
Expand Down