Merge pull request #195 from Giskard-AI/GSK-234_improve_current_tests

Gsk 234 improve current tests

Author: andreybavt

giskard-frontend/src/generated-sources/ai/giskard/web/dto/ml/single-test-result-dto.ts

@@ -1,8 +1,11 @@
+import type {TestResultMessageDTO} from './test-result-message-dto';
+
 /**
  * Generated from ai.giskard.web.dto.ml.SingleTestResultDTO
  */
 export interface SingleTestResultDTO {
     actualSlicesSize: number[];
+    messages: TestResultMessageDTO[];
     metric: number;
     missingCount: number;
     missingPercent: number;

giskard-frontend/src/generated-sources/ai/giskard/web/dto/ml/test-result-message-dto.ts

@@ -0,0 +1,7 @@
+/**
+ * Generated from ai.giskard.web.dto.ml.TestResultMessageDTO
+ */
+export interface TestResultMessageDTO {
+    text: string;
+    type: any /* TODO: Missing translation of ai.giskard.worker.TestMessageType */;
+}

giskard-frontend/src/generated-sources/index.ts

@@ -38,6 +38,7 @@ export const GENERATED_MAPPING = {
     'ai.giskard.web.dto.ml.TestEditorConfigDTO' : 'TestEditorConfigDTO',
     'ai.giskard.web.dto.ml.TestExecutionResultDTO' : 'TestExecutionResultDTO',
     'ai.giskard.web.dto.ml.TestExecutionStatusDTO' : 'TestExecutionStatusDTO',
+    'ai.giskard.web.dto.ml.TestResultMessageDTO' : 'TestResultMessageDTO',
     'ai.giskard.web.dto.ml.TestSuiteDTO' : 'TestSuiteDTO',
     'ai.giskard.web.dto.ml.UpdateTestSuiteDTO' : 'UpdateTestSuiteDTO',
     'ai.giskard.web.dto.ml.write.FilePostDTO' : 'FilePostDTO',
@@ -99,6 +100,7 @@ export * from './ai/giskard/web/dto/ml/test-dto';
 export * from './ai/giskard/web/dto/ml/test-editor-config-dto';
 export * from './ai/giskard/web/dto/ml/test-execution-result-dto';
 export * from './ai/giskard/web/dto/ml/test-execution-status-dto';
+export * from './ai/giskard/web/dto/ml/test-result-message-dto';
 export * from './ai/giskard/web/dto/ml/test-suite-dto';
 export * from './ai/giskard/web/dto/ml/update-test-suite-dto';
 export * from './ai/giskard/web/dto/ml/write/file-post-dto';

giskard-frontend/src/generated-sources/j2ts-generated-metadata.json

@@ -41,6 +41,7 @@
     "ai.giskard.web.dto.ml.DatasetDTO": "DatasetDTO",
     "ai.giskard.web.dto.PredictionDTO": "PredictionDTO",
     "ai.giskard.web.dto.user.AdminUserDTO$AdminUserDTOWithPassword": "AdminUserDTO.AdminUserDTOWithPassword",
+    "ai.giskard.web.dto.ml.TestResultMessageDTO": "TestResultMessageDTO",
     "ai.giskard.web.dto.DataUploadParamsDTO": "DataUploadParamsDTO",
     "ai.giskard.web.dto.ml.write.TestSuitePostDTO": "TestSuitePostDTO",
     "ai.giskard.domain.ml.ModelLanguage": "ModelLanguage",

giskard-frontend/src/views/main/project/TestEditor.vue

@@ -175,8 +175,11 @@
               <div class="text-body-2">{{ runResult.executionDate | date }}</div>
             </div>
             <div class="d-flex justify-space-between align-center">
-              <div class='text-body-2'>Metric: {{ testResult.result.metric  }}</div>
-<!--              <a class="text-body-2 results-link text-decoration-underline">Full results</a>-->
+              <div class='text-body-2'>Metric: {{ testResult.result.metric }}</div>
+              <div class='text-body-2' v-if="testResult.result.messages && testResult.result.messages.length">
+                {{ testResult.result.messages[0].text }}
+              </div>
+              <!--              <a class="text-body-2 results-link text-decoration-underline">Full results</a>-->
             </div>
           </v-alert>
         </template>

giskard-ml-worker/ml_worker/core/giskard_dataset.py

@@ -16,6 +16,10 @@ def __init__(self, df: pd.DataFrame, target: Optional[str], feature_types: Dict[
         self.feature_types = feature_types
         self.column_types = column_types
 
+    @property
+    def columns(self):
+        return self.df.columns
+
     def slice(self, slice_fn: Callable):
         if slice_fn is None:
             return self