Giskard-AI
diff --git a/‎tests/rag/test_report.py‎
Lines changed: 6 additions & 26 deletions b/‎tests/rag/test_report.py‎
Lines changed: 6 additions & 26 deletions
@@ -2,6 +2,7 @@
 from unittest.mock import Mock, patch
 
 import numpy as np
+import pytest
 from bokeh.plotting import figure
 
 from giskard.rag import QATestset, RAGReport
@@ -98,34 +99,13 @@ def test_report_plots():
     assert len(histograms["Question"]["simple"]) == 4
 
 
-def test_report_to_html_with_embed():
-    """Test that to_html works correctly with embed=True parameter."""
+@pytest.mark.parametrize("embed", [False, True])
+def test_report_to_html(embed):
+    """Test that to_html works correctly with different embed parameter values."""
     testset, answers, metrics_results = _create_test_data()
-    knowledge_base = Mock()
-
-    report = RAGReport(testset, answers, metrics_results, knowledge_base)
-
-    # Test to_html with embed=False (default behavior)
-    html_output = report.to_html(embed=False)
-    assert html_output is not None
-    assert isinstance(html_output, str)
-    assert html_output.startswith("<!DOCTYPE html>")
 
-    # Test to_html with embed=True
-    embedded_output = report.to_html(embed=True)
-    assert embedded_output is not None
-
-    # When embed=True, it should return an IPython HTML display object
-    from IPython.core.display import HTML
-
-    assert isinstance(embedded_output, HTML)
-
-    # The embedded output should contain an iframe with the escaped HTML content
-    iframe_html = embedded_output.data
-    assert "<iframe" in iframe_html
-    assert "srcdoc=" in iframe_html
-    assert "width=100%" in iframe_html
-    assert "height=800px" in iframe_html
+    report = RAGReport(testset, answers, metrics_results)
+    report.to_html(embed=embed)
 
 
 def test_report_save_load(tmp_path):