Merge branch 'main' into qatest_push_to_hub

Author: henchaves

giskard/core/core.py

@@ -8,13 +8,13 @@
 from enum import Enum
 from pathlib import Path
 
-from griffe import Docstring
-from griffe.docstrings.dataclasses import (
+from griffe import (
+    Docstring,
     DocstringSection,
+    DocstringSectionKind,
     DocstringSectionParameters,
     DocstringSectionReturns,
 )
-from griffe.enumerations import DocstringSectionKind
 
 from ..utils.artifacts import serialize_parameter
 
@@ -26,7 +26,7 @@
 from typing import Any, Callable, Dict, List, Literal, Optional, Type, TypeVar, Union
 
 logger = logging.getLogger(__name__)
-DEMILITER = f"\n{'='*20}\n"
+DEMILITER = f"\n{'=' * 20}\n"
 
 
 class Kwargs:

giskard/rag/report.py

@@ -7,7 +7,6 @@
 import matplotlib
 import numpy as np
 import pandas as pd
-from IPython.core.display import HTML
 
 from ..llm.client.base import LLMClient
 from ..llm.embeddings.base import BaseEmbedding
@@ -135,6 +134,8 @@ def to_html(self, filename=None, embed=False):
             return
 
         if embed:
+            from IPython.core.display import HTML
+
             return HTML(f'<iframe srcdoc="{escape(html)}" width=100% height=800px></iframe>')
         return html
 

pyproject.toml

@@ -81,7 +81,7 @@ ml_runtime = [
 ]
 test = [
     "google.generativeai",
-    "nemoguardrails>=0.9.0",
+    "nemoguardrails>=0.9.0, <0.11.0", # 0.11.0 ensure align with langchain<0.3.0
     "onnxruntime<1.20.0",
     "openai>=1",
     "polyfactory",
@@ -174,7 +174,8 @@ dependencies = [
     "markdown",                 # needed for display of scan results in notebook
     "colorama",                 # needed for the scan
     "num2words>=0.5.13",
-    "griffe>=0.36.9, <0.49.0",
+    "griffe>=1.0.0,<2.0.0",
+    "ipython",
 ]
 
 [project.optional-dependencies]

tests/rag/test_report.py

@@ -2,6 +2,7 @@
 from unittest.mock import Mock, patch
 
 import numpy as np
+import pytest
 from bokeh.plotting import figure
 
 from giskard.rag import QATestset, RAGReport
@@ -98,6 +99,15 @@ def test_report_plots():
     assert len(histograms["Question"]["simple"]) == 4
 
 
+@pytest.mark.parametrize("embed", [False, True])
+def test_report_to_html(embed):
+    """Test that to_html works correctly with different embed parameter values."""
+    testset, answers, metrics_results = _create_test_data()
+
+    report = RAGReport(testset, answers, metrics_results)
+    report.to_html(embed=embed)
+
+
 def test_report_save_load(tmp_path):
     testset, answers, metrics_results = _create_test_data(with_documents=True)
     llm_client = Mock()