Fix retry decorators to re-raise last exception (#110) #130
+57
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes an edge case in the retry decorators where, when all retry attempts fail, the decorator raised a generic
MemoriError("Retry attempts exhausted")instead of re-raising the original (last) exception. This masked thereal error and made debugging difficult.
Changes
memori/utils/helpers.pyretry_on_exceptionandasync_retry_on_exceptionnow re-raise the last exception (preserving traceback)if present;
MemoriErroris only raised as a fallback if no exception was captured.tests/test_retry_helpers.py(new)CHANGELOG.mdMotivation and Context
Fixes #110 (Hacktoberfest) – consumers could not see the real exception causing retry failures because it was replaced
by a generic
MemoriError. With this change, the original exception (and its traceback) will be surfaced.How to Test