ro1.php

[CristinaEU1]

Added Romanian language with native Romanian letters

Description

Fixes #

Type of change

• Bug fix (added a non-breaking change which fixes an issue)
• New feature (added a non-breaking change which adds functionality)
• Updated documentation (updated the readme, templates, or other repo files)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

• Tested locally with a valid username
• Tested locally with an invalid username
• Ran tests with composer test
• Added or updated test cases to test new features

Checklist:

• I have checked to make sure no other pull requests are open for this issue
• The code is properly formatted and is consistent with the existing code style
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings

Screenshots

[CristinaEU1]

Please review, thanks!

[CristinaEU1]

please review

[DenverCoder1]

Any reason to call this ro_cuDiacritice instead of ro for simplicity? Would there need to be other versions of Romanian supported separately?

Suggested change

	"ro_cuDiacritice" => [
	"ro" => [

[R055A]

@CristinaEU1 this is failing the CI test:

Locale 'ro_cuDiacritice' is not normalized. Expected 'ro'.

[DenverCoder1]

Yes, currently the script expects the locale to have a language code (2 to 3 letters), optionally followed by a script code (4 letters), optionally followed by a region code (2 letters or 3 numbers), for example, "ro", "ro_RO", "ro_MD" are options, sometimes we use scripts like "zh_Hans" to differentiate from "zh_Hant", but in general we only specify region and script if it's not the "typical" for this language. We can change the normalization if we need to, but in this case, I think Romanian should just be "ro" because (as far as I know) we won't need to implement a version of Romanian without diacritice.

https://github.com/DenverCoder1/github-readme-streak-stats/blob/main/src%2Fcard.php#L265