Skip to content

Commit 5cd0d78

Browse files
nxdefiantDLu
authored andcommitted
range sensor layer: Remove parameter max_angle (#38)
Any value set for max_angle gets overwritten in updateCostmap() so the parameter can safely be removed.
1 parent 11becc9 commit 5cd0d78

File tree

2 files changed

+0
-2
lines changed

2 files changed

+0
-2
lines changed

‎range_sensor_layer/cfg/RangeSensorLayer.cfg‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@ gen = ParameterGenerator()
77

88
gen.add('enabled', bool_t, 0, 'Whether to apply this plugin or not', True)
99
gen.add('phi', double_t, 0, 'Phi value', 1.2)
10-
gen.add('max_angle', double_t, 0, 'Maximum angle (radians)', 12.5*3.14/180, 0, 3.1415)
1110
gen.add('inflate_cone', double_t, 0, 'Inflate the triangular area covered by the sensor (percentage)', 1, 0, 1)
1211
gen.add('no_readings_timeout', double_t, 0, 'No Readings Timeout', 0.0, 0.0)
1312
gen.add('clear_threshold', double_t, 0, 'Probability below which cells are marked as free', 0.2, 0.0, 1.0)

‎range_sensor_layer/src/range_sensor_layer.cpp‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -153,7 +153,6 @@ double RangeSensorLayer::sensor_model(double r, double phi, double theta)
153153
void RangeSensorLayer::reconfigureCB(range_sensor_layer::RangeSensorLayerConfig &config, uint32_t level)
154154
{
155155
phi_v_ = config.phi;
156-
max_angle_ = config.max_angle;
157156
inflate_cone_ = config.inflate_cone;
158157
no_readings_timeout_ = config.no_readings_timeout;
159158
clear_threshold_ = config.clear_threshold;

0 commit comments

Comments
 (0)