Skip to content

Conversation

@SagoLu
Copy link
Contributor

@SagoLu SagoLu commented Oct 31, 2025

What this PR does

Before this PR:

After this PR:

Fixes #

Why we need it and why it was done in this way

The following tradeoffs were made:

The following alternatives were considered:

Links to places where the discussion took place:

Breaking changes

If this PR introduces breaking changes, please describe the changes and the impact on users.

Special notes for your reviewer

Checklist

This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.

Release note


Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the mini_window shortcut handling by moving the QuickAssistant enablement check from registration time to runtime (when the shortcut is triggered). This allows the shortcut to be dynamically registered/unregistered based on the shortcut's enabled state, while checking the QuickAssistant feature flag only when the shortcut is actually invoked.

Key Changes

  • Moved the QuickAssistant enabled check from the registerShortcuts function into the getShortcutHandler function for the mini_window shortcut
  • Removed the early return condition during shortcut registration that prevented registration when QuickAssistant was disabled
  • Added logging statements to track when the shortcut is processed during registration and when it's triggered

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants