-
Notifications
You must be signed in to change notification settings - Fork 3.2k
feat: reset default model #11054
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
EurFelux
wants to merge
11
commits into
v2
Choose a base branch
from
feat/reset-default-model
base: v2
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat: reset default model #11054
+142
−75
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
commit history seems wrong? |
|
Rebase is not finished. Waiting for the next v2 merge main |
- Replace SYSTEM_MODELS.defaultModel array with DEFAULT_MODEL_MAP object for clearer model assignments - Update related store and hook implementations to use new model map - Add reset functions for default models in useAssistant hook
Add reset functionality for default assistant, quick and translate models. Replace RedoOutlined icon with custom ResetIcon for consistency.
…n and update button styles migrate icon usage to custom ResetIcon component and improve button styling add TODO comment for future button component migration
Use setQuickModel instead of setTranslateModel to properly reset the quick model
Replace SYSTEM_MODELS.defaultModel array with DEFAULT_MODEL_MAP object to better reflect actual model structure
cff0f0e to
c49c592
Compare
…-studio into feat/reset-default-model
…stid Update test snapshot to reflect changes in the InputEmbeddingDimension component where a testid was added to the button and the data-title attribute was removed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request implements a feature to allow users to reset their selected default model back to an unselected state, addressing issue #11024.
Problem Solved
Users who had selected a default model in Cherry Studio previously had no way to return to the state where no model was selected. This was limiting for users who wanted to start fresh or change their model selection strategy.
Implementation
The PR adds reset functionality to the model settings, including:
ResetIconcomponent instead ofRedoOutlinedKey Changes
User Impact
Users can now easily reset their default model selection, providing more flexibility in model management and allowing them to return to a clean slate state as requested in the original feature request.
Fixes #11024