Skip to content

Conversation

@savasava034
Copy link

What this PR does

Before this PR:

After this PR:

Fixes #

Why we need it and why it was done in this way

The following tradeoffs were made:

The following alternatives were considered:

Links to places where the discussion took place:

Breaking changes

If this PR introduces breaking changes, please describe the changes and the impact on users.

Special notes for your reviewer

Checklist

This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.

Release note


Copilot AI review requested due to automatic review settings October 26, 2025 15:23
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@savasava034 savasava034 reopened this Oct 26, 2025
@EurFelux
Copy link
Collaborator

Please mark it as "ready for review" only after you have finished writing the PR title and description.

@EurFelux EurFelux marked this pull request as draft October 26, 2025 15:48
@savasava034
Copy link
Author

savasava034 commented Oct 26, 2025

[!NOTE]

This issue/comment/review was translated by Claude.

Hello — Turkish locale and Windows build workflow added. I kindly request you to review and make it ready for merge.


Original Content

Merhaba — Türkçe locale ve Windows build workflow eklendi. İncelemeniz ve merge için hazır hale getirmenizi rica ediyorum.

@savasava034 savasava034 marked this pull request as ready for review October 26, 2025 16:16
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I took a quick look, and there's still a lot of English in the document.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additionally, our script check has detected that the file you added is not a valid JSON file.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is redundant.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is redundant.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wrong extension

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you explain why we need it?

@EurFelux EurFelux changed the title src/renderer/src/i18n/locales/ Oct 26, 2025
@0xfullex 0xfullex added the Blocked: v2 The PR is blocked until v2 released label Oct 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Blocked: v2 The PR is blocked until v2 released

3 participants