fix: verbosity setting not applied & related types refactor #10964
+252
−89
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Move OpenAI-related types to aiCoreTypes.ts - Rename FetchChatCompletionOptions to FetchChatCompletionRequestOptions - Add proper type definitions for service tiers and verbosity - Improve type guards for service tier checks
…ency Update parameter name across multiple files to use requestOptions instead of options for better clarity and consistency in API calls
…ype safety - Remove 'off' option from OpenAISummaryText type and use null instead - Add migration to convert 'off' values to null - Add utility function to convert undefined to null - Update Selector component to handle null/undefined values - Improve type safety in provider options and reasoning params
Consolidate utility functions into shared package to improve code organization and reuse
This reverts commit 68bd7ea.
Add "off" translation for multiple languages and remove "performance" service tier option from translations
EurFelux
commented
Oct 25, 2025
Add comments to explain that undefined is treated as default and null as explicitly off in OpenAIVerbosity and OpenAIServiceTier types. Also update type safety for OpenAIServiceTiers record.
|
Note This issue/comment/review was translated by Claude. You can install the @ai-sdk/groq dependency, the officially maintained one should have some input parameter validation Original Content可以安装一下 @ai-sdk/groq依赖，官方维护的应该有一些入参校验 |
DeJeune
approved these changes
Oct 25, 2025
|
Note This issue/comment/review was translated by Claude. I took a look, and the type definitions are not great. reasoningEffort is even a pure string type. Original Content看了一下，类型定义不太行，reasoningEffort甚至是纯string类型 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Before this PR:
After this PR:
Fixes #10963
Why we need it and why it was done in this way
The following tradeoffs were made:
The following alternatives were considered:
Links to places where the discussion took place:
Breaking changes
If this PR introduces breaking changes, please describe the changes and the impact on users.
Special notes for your reviewer
Checklist
This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.
Release note