-
Notifications
You must be signed in to change notification settings - Fork 3.2k
feature: model group mention #10949
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feature: model group mention #10949
Conversation
|
The feature PR won't be merged before v2, as v2 will involve a major data architecture refactoring. |
How long until the v2 release? |
|
It's expected in next month |
|
Note This issue/comment/review was translated by Claude.
Original Content
|
|
You can change the base branch to v2 and see what other modifications might be needed. Let's discuss this issue together; my idea is to move it to the assistant settings. |
|
I realized I overlooked the discussion related to #10006; perhaps I simply forgot about it at the time. Additionally, since we didn't prominently announce our plans to the community, you ended up wasting effort writing unnecessary code, and for that, I must apologize to you as well. Well, the functionality intended for #10006 should have been merged before 1.6.0, as we decided in principle not to merge any PRs affecting data after 1.6.0. So, it's somewhat delayed now. After a quick look at the changes in this PR, I noticed it involves entirely new data types. Therefore, as @DeJeune mentioned, you can rebase these changes onto the v2 branch. However, since the user data architecture portion of the v2 branch hasn't been fully designed yet, I suggest postponing this matter. If you're eager to use this feature, you're certainly welcome to build your own version. |
|
Note This issue/comment/review was translated by Claude. I'm definitely eager to use this model group feature, to reduce the substantial daily effort of manually selecting models. But this time you guys provide timely responses which make good sense. I understand that data architecture refactoring will be the priority. Hopefully the team can remember this feature, I'm still very hopeful to get this feature as soon as v2 is ready. I'll also try to see if I can squeeze time at weekends to attempt to have a look Original Content我确实很想使用这个模型分组功能,以减少手动选择模型的日常工作量。但这次你们提供了及时且合理的回应。我理解数据架构重构将成��优先事项。 希望团队能记住这个功能,我仍然非常有希望在 v2 准备好时尽快获得这个功能。我也会试着看看是否能在周末挤出时间来看看 |
|
Thank you for your understanding. |
What this PR does
Revising and Enhancement of #10006
Before this PR:
After this PR:
2025-10-25.05-16-22.1.mp4
Fixes #[issue number if applicable]
Why we need it and why it was done in this way
This feature addresses the need for easier multi-model conversations by allowing users to pre-define groups of models they frequently use together. Instead of @mentioning models individually each time, users can create a group once and @mention it.
Tradeoffs made:
Alternatives considered:
Breaking changes
None. This is a new feature that doesn't modify existing functionality.
Special notes for your reviewer
Key implementation details:
src/renderer/src/types/index.ts): AddedModelGroupandModelReferencetypessrc/renderer/src/store/modelGroups.ts): Complete CRUD operations with auto-generated IDs and timestampssrc/renderer/src/pages/settings/ModelGroupSettings/): 5 components following existing patternsTesting focus areas:
Checklist
Release note