Skip to content

fix: Incorrect navigation when creating new message with @ #10930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: Incorrect navigation when creating new message with @ #10930

wants to merge 2 commits into from

Conversation

@EurFelux
Copy link
Collaborator

What this PR does

Before this PR: as #10928 said

After this PR: fixed

Fixes #10928

Why we need it and why it was done in this way

The following tradeoffs were made:

The following alternatives were considered:

Links to places where the discussion took place:

Breaking changes

If this PR introduces breaking changes, please describe the changes and the impact on users.

Special notes for your reviewer

Checklist

This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.

Release note
@EurFelux
fix(message): Incorrect navigation when creating new message with @
9e20314 
Update variable name from newAssistantStub to newAssistantMessageStub for clarity
Add dispatch calls to update message folding state
Remove unused message length tracking effect in MessageGroup

Fixes #10928
@EurFelux
refactor(MessageGroup): remove unused prevMessageLengthRef variable
618c636
@EurFelux EurFelux requested a review from 0xfullex as a code owner October 23, 2025 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@EurFelux