Skip to content

Conversation

@CGastrell
Copy link
Contributor

Proposed changes:

This PR is an exploration to set up DataViews and make use of the mediaField prop to show avatars.

It does carry some minimal style override, which we're trying not to, but it was the only way to have play nice with the list.

image image image

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

p1761739561258309-slack-C052XEUUBL4

Does this pull request change what data or activity we track or use?

No

Testing instructions:

Visit the Forms dashboard. See the new avatars implementation. Use the view cog to hide/show the avatar.

@CGastrell CGastrell self-assigned this Oct 29, 2025
@CGastrell CGastrell added [Status] In Progress [Type] Task [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Package] Forms Coverage tests to be added later Use to ignore the Code coverage requirement check when tests will be added in a follow-up PR labels Oct 29, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Oct 29, 2025

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack), and enable the add/forms-native-dataviews-media-display branch.
  • To test on Simple, run the following command on your sandbox:
bin/jetpack-downloader test jetpack add/forms-native-dataviews-media-display

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2
@github-actions
Copy link
Contributor

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  • ✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!


Jetpack plugin:

The Jetpack plugin has different release cadences depending on the platform:

  • WordPress.com Simple releases happen as soon as you deploy your changes after merging this PR (PCYsg-Jjm-p2).
  • WoA releases happen weekly.
  • Releases to self-hosted sites happen monthly:
    • Scheduled release: November 4, 2025
    • Code freeze: November 3, 2025

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

@jp-launch-control
Copy link

jp-launch-control bot commented Oct 29, 2025

Code Coverage Summary

Coverage changed in 2 files.

File Coverage Δ% Δ Uncovered
projects/packages/forms/src/dashboard/inbox/dataviews/index.js 0/112 (0.00%) 0.00% 2 ❤️‍🩹
projects/packages/forms/src/dashboard/components/gravatar/index.tsx 0/11 (0.00%) 0.00% 1 ❤️‍🩹

Full summary · PHP report · JS report

Coverage check overridden by Coverage tests to be added later Use to ignore the Code coverage requirement check when tests will be added in a follow-up PR .

}

// Override DataViews default max-width for media in primary column
// to better fit smaller avatars (24x24 instead of larger preview images)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With Fields API it sounds like we can have sizes option? https://github.com/WordPress/gutenberg/tree/trunk/packages/dataviews#render

Comment on lines 229 to 230
width={ 24 }
height={ 24 }
Copy link
Member

@simison simison Oct 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

max-width is 32px so let's match the image size with that, and the actual image that loads should be 2x (64px) so that it looks good on all screens.

label: __( 'Avatar', 'jetpack-forms' ),
render: ( { item } ) => {
return (
<img
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Gravatar component also returns an img, why not use that here? I don't actually mind if it's backend or frontend driven as long as it's consistent. :-) That said, we now rely on backend for a frontend visual implementation (image size), which isn't a good practice.

The fallback looks different from before (mystery instead of initials) and it's missing when email isn't there — let's show some fallback image then:

Image Image
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The initials were provided by the Gravatar component, unsure if that's a Gravatar feature (return an image with initials) or some sort of fallback provided by the component. Same goes for mystery avatar, I think it must be some fallback we're providing on backend. I'll look into recover that functionality before merging today.

@CGastrell CGastrell force-pushed the add/forms-native-dataviews-media-display branch 2 times, most recently from 5ff9fed to be82db3 Compare October 31, 2025 15:47
@CGastrell CGastrell force-pushed the add/forms-native-dataviews-media-display branch from be82db3 to e6e2af3 Compare October 31, 2025 20:01
Copy link
Member

@simison simison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't tested after last changes but code looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Coverage tests to be added later Use to ignore the Code coverage requirement check when tests will be added in a follow-up PR [Feature] Contact Form [Package] Forms [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Status] In Progress [Type] Task

3 participants