Forms: Update dataview actions

[dhasilva]

Part of FORMS-330
Depends on #45735

Proposed changes:

• Updates the dataview dependency
• Uses text instead of icons for primary actions (required the dependency update)
• Contextualize actions depending on the status

Other information:

• Have you written new tests for your changes, if applicable?
• Have you checked the E2E test CI results, and verified that your changes do not break them?
• Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

• Go to the dashboard
• Check that primary actions now use text instead of icons
• Check that the inbox, spam and trash views show contextualized actions based on the design exploration

[github-actions]

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

• To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack), and enable the update/forms-dashboard-dataview-actions branch.
• To test on Simple, run the following command on your sandbox:

bin/jetpack-downloader test jetpack update/forms-dashboard-dataview-actions

Interested in more tips and information?

• In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
• Read more about our development workflow here: PCYsg-eg0-p2
• Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

[github-actions]

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

• ✅ Include a description of your PR changes.
  
• ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  
• ✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  
• ✅ Add testing instructions.
  
• ✅ Specify whether this PR includes any changes to data or privacy.
  
• ✅ Add changelog entries to affected projects
  

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

---

Follow this PR Review Process:

1. Ensure all required checks appearing at the bottom of this PR are passing.
2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
3. You can use GitHub's Reviewers functionality to request a review.
4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

[jp-launch-control]

Code Coverage Summary

Coverage changed in 1 file.

File	Coverage	Δ%	Δ Uncovered
projects/packages/forms/src/dashboard/inbox/dataviews/index.js	0/128 (0.00%)	0.00%	18 💔

2 files are newly checked for coverage.

File	Coverage
projects/packages/forms/src/dashboard/inbox/dataviews/actions.tsx	0/212 (0.00%) 💔
projects/packages/forms/src/dashboard/inbox/dataviews/types.tsx	0/0 (—%) 🤷

Full summary · PHP report · JS report

_{Coverage check overridden by I don't care about code coverage for this PR Use this label to ignore the check for insufficient code coveage. .}

[ilonagl]

We need at least the response title clickable. Or we can add additional 'View' action next to 'Trash' until we get that one, and proceed with duplication of actions until we get that one as well. Thoughts?

[ilonagl]

@dhasilva how hard is it to experiment with actions here now and try different approaches? I wonder if we could add 'View' as an action, and and also 'Mark as spam'?

[simison]

Let's update the package dependency in a separate PR to keep this one more focused on just curating right actions:

• Update dependency @wordpress/dataviews to v10.1.0 (take 2) #45625

That said, let's not update the dependency until we have upstream fix available for mobile multi-actions:

• DataViews: Keep icon-only buttons on mobile for bulk actions WordPress/gutenberg#72761

[keoshi]

+1 for adding “View” as it seems is the primary action we want to surface. At least until we decide on making the entire row clickable for the primary action, which I've commented on here: ARC-1132#comment-eeac5fd5

[dhasilva]

how hard is it to experiment with actions here now and try different approaches? I wonder if we could add 'View' as an action, and and also 'Mark as spam'?

Sure, I can do that.

[Status] Blocked / Hold Depends on the dependency update PR.

[ilonagl]

@dhasilva here are the updated designs