Do not animate layout if keyboard state is not changed. #66
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am still getting this warning. Is there a way that hide this in the production version? |
|
This pull request fixed the "Warning: Overriding previous layout animation..." issue. |
SnaiNeR
added a commit
to maxiru/react-native-keyboard-spacer
that referenced
this pull request
Jun 10, 2020
Andr3wHur5t#66 I've found that closing a modal cause keyboard to open and then immediately hide, which causes multiple calls of resetKeyboardSpace function, and this causes an error: Warning: Overriding previous layout animation Which affects Modal somehow, because it could not be hidden after this warning.
KrisLau
approved these changes
Aug 5, 2021
|
same issue |
|
Getting this warning on latest package. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've found that closing a modal cause keyboard to open and then immediately hide, which causes multiple calls of resetKeyboardSpace function, and this causes an error:
Warning: Overriding previous layout animation
Which affects Modal somehow, because it could not be hidden after this warning.