Fix #4306: Handle symlink loops in safe_abs_path #4579
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ap config_writer() in try-except block - Add graceful error handling for permission issues - Prevents crash when using repositories on network drives - Fixes Aider-AI#4508
…me-no-background flag to disable backgrounds - Implement CustomMarkdown renderer with background control - Clear menu background colors in light mode - Add theme utilities for background removal - Update light-mode to work properly on light terminals - Fixes Aider-AI#4519
- Added RuntimeError exception handling for circular symlinks - Fall back to absolute() when resolve() encounters symlink loop - Added test case in tests/test_utils_symlinks.py - Fixes issue where aider crashes on circular symbolic links
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #4306 - Handles RuntimeError when encountering circular symlinks in the repository.
Changes
safe_abs_path()inaider/utils.pyto catch RuntimeError for symlink loopsPath.absolute()whenPath.resolve()encounters circular symlinksstrict=Falseparameter to handle broken symlinks gracefullytests/test_utils_symlinks.pyto verify the fixTesting
Related Issue
Closes #4306