Skip to content

Conversation

@Lms24
Copy link
Member

@Lms24 Lms24 commented Jun 23, 2022

As already discussed in #5292, this PR moves the getBaggage() method from the Span class, to the Transaction class. This change is good for two reasons:

  1. It conceptually makes more sense to store DSC on the transaction rather than the span because we're always talking about transactions in DS
  2. We can get rid of a sketchy type cast and avoid a circular dependency situation (transaction -> span -> transaction) entirely
@github-actions
Copy link
Contributor

github-actions bot commented Jun 23, 2022

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 19.39 KB (added)
@sentry/browser - ES5 CDN Bundle (minified) 59.95 KB (added)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 18.18 KB (added)
@sentry/browser - ES6 CDN Bundle (minified) 53.57 KB (added)
@sentry/browser - Webpack (gzipped + minified) 19.96 KB (added)
@sentry/browser - Webpack (minified) 65.02 KB (added)
@sentry/react - Webpack (gzipped + minified) 19.98 KB (added)
@sentry/nextjs Client - Webpack (gzipped + minified) 44.22 KB (added)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 25.79 KB (added)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 24.25 KB (added)
@Lms24 Lms24 force-pushed the lms-baggage-transaction branch from 55cc445 to 9982f57 Compare June 23, 2022 12:54
@Lms24 Lms24 marked this pull request as ready for review June 23, 2022 13:20
@Lms24 Lms24 requested review from AbhiPrasad and lforst June 23, 2022 13:21
@Lms24 Lms24 self-assigned this Jun 23, 2022
Co-authored-by: Abhijeet Prasad <aprasad@sentry.io>
@Lms24 Lms24 enabled auto-merge (squash) June 23, 2022 14:35
@Lms24 Lms24 merged commit cb2462b into master Jun 23, 2022
@Lms24 Lms24 deleted the lms-baggage-transaction branch June 23, 2022 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants