Skip to content

Allows passing size or custom alphabet via cli as args #334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 16, 2022
Merged

Allows passing size or custom alphabet via cli as args #334

merged 2 commits into from
Jan 16, 2022

Conversation

@vitalybaev
Copy link
Contributor

@vitalybaev vitalybaev commented Jan 15, 2022

Closes #275

I've implemented minimal args parsing logic to fit our needs and be as little as possible
ai
ai reviewed Jan 15, 2022
View reviewed changes
@ai
Copy link
Owner

ai commented Jan 15, 2022

We need to improve test coverage. You can check test coverage locally by running pnpm test.
@ai
Copy link
Owner

ai commented Jan 15, 2022

We also need to fix Node.js 12 support for binary (we can’t use ??)
@vitalybaev
Copy link
Contributor Author

vitalybaev commented Jan 16, 2022

Done

I've faced error ERROR dual-publish error: Rename bin/utils.js to bin/utils/index.js, so I moved file according to this message.

Now it still works with Node 12 and test coverage is 100%
@ai ai merged commit 32b9bda into ai:main Jan 16, 2022
@vitalybaev vitalybaev deleted the feature/cli-args branch January 16, 2022 14:06
@ai
Copy link
Owner

ai commented Jan 16, 2022

bin/utils will create unnecessary files because of dual-publish. I cleaned up arguments parsing a little 27eaa90

And released in 3.2.
@sync-by-unito sync-by-unito bot mentioned this pull request Jan 27, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@vitalybaev @ai