Fix assertion failure in pg_prewarm() on objects without storage.
authorFujii Masao <fujii@postgresql.org>
Thu, 29 May 2025 08:50:32 +0000 (17:50 +0900)
committerFujii Masao <fujii@postgresql.org>
Thu, 29 May 2025 08:50:32 +0000 (17:50 +0900)
commit3c4d7557e03ba1ca988a2d1a2518a4ad93976f86
tree2b7fffa51cc21fb9a11aeb2600b78ec919f9b66d
parentc3623703f3630c7b89adc865bbec7cb55e87185a
Fix assertion failure in pg_prewarm() on objects without storage.

An assertion test added in commit 049ef33 could fail when pg_prewarm()
was called on objects without storage, such as partitioned tables.
This resulted in the following failure in assert-enabled builds:

    Failed Assert("RelFileNumberIsValid(rlocator.relNumber)")

Note that, in non-assert builds, pg_prewarm() just failed with an error
in that case, so there was no ill effect in practice.

This commit fixes the issue by having pg_prewarm() raise an error early
if the specified object has no storage. This approach is similar to
the fix in commit 4623d7144 for pg_freespacemap.

Back-patched to v17, where the issue was introduced.

Author: Masahiro Ikeda <ikedamsh@oss.nttdata.com>
Reviewed-by: Dilip Kumar <dilipbalaut@gmail.com>
Reviewed-by: Richard Guo <guofenglinux@gmail.com>
Reviewed-by: Fujii Masao <masao.fujii@gmail.com>
Discussion: https://postgr.es/m/e082e6027610fd0a4091ae6d033aa117@oss.nttdata.com
Backpatch-through: 17
contrib/pg_prewarm/Makefile
contrib/pg_prewarm/expected/pg_prewarm.out [new file with mode: 0644]
contrib/pg_prewarm/meson.build
contrib/pg_prewarm/pg_prewarm.c
contrib/pg_prewarm/sql/pg_prewarm.sql [new file with mode: 0644]