perf: #3587806 Add placeholdering to help, messages, branding blocks (e461cedb) · Commits · project / drupal

core/modules/help/src/Plugin/Block/HelpBlock.php

+7 −0

Original line number	Diff line number	Diff line
		@@ -108,4 +108,11 @@ public function getCacheContexts() {
		return Cache::mergeContexts(parent::getCacheContexts(), ['route']);
		}

		/**
		* {@inheritdoc}
		*/
		public function createPlaceholder(): bool {
		return TRUE;
		}

		}

+7 −0

Original line number	Diff line number	Diff line
		@@ -156,4 +156,11 @@ public function getCacheTags() {
		);
		}

		/**
		* {@inheritdoc}
		*/
		public function createPlaceholder(): bool {
		return TRUE;
		}

		}

+7 −0

Original line number	Diff line number	Diff line
		@@ -48,4 +48,11 @@ public function getCacheMaxAge() {
		return Cache::PERMANENT;
		}

		/**
		* {@inheritdoc}
		*/
		public function createPlaceholder(): bool {
		return TRUE;
		}

		}

+5 −5

Original line number	Diff line number	Diff line
		@@ -127,25 +127,25 @@ protected function doTestNodePageAdministrator(): void {

		$expected = [
		'QueryCount' => 263,
		'CacheGetCount' => 257,
		'CacheGetCount' => 253,
		'CacheGetCountByBin' => [
		'config' => 62,
		'bootstrap' => 16,
		'discovery' => 75,
		'data' => 19,
		'data' => 20,
		'entity' => 24,
		'dynamic_page_cache' => 1,
		'default' => 20,
		'render' => 18,
		'render' => 13,
		'menu' => 22,
		],
		'CacheSetCount' => 256,
		'CacheSetCount' => 257,
		'CacheDeleteCount' => 0,
		'CacheTagInvalidationCount' => 0,
		'CacheTagLookupQueryCount' => 28,
		'ScriptCount' => 4,
		'ScriptBytes' => 200400,
		'StylesheetCount' => 6,
		'StylesheetCount' => 7,
		'StylesheetBytes' => 79412,
		];
		$this->assertMetrics($expected, $performance_data);

+3 −3

Original line number	Diff line number	Diff line
		@@ -53,7 +53,7 @@ protected function testFrontPageColdCache(): void {

		$expected = [
		'QueryCount' => 183,
		'CacheGetCount' => 232,
		'CacheGetCount' => 227,
		'CacheSetCount' => 237,
		'CacheDeleteCount' => 0,
		'CacheTagLookupQueryCount' => 24,
		@@ -123,11 +123,11 @@ protected function testFrontPageCoolCache(): void {

		$expected = [
		'QueryCount' => 58,
		'CacheGetCount' => 172,
		'CacheGetCount' => 167,
		'CacheSetCount' => 74,
		'CacheDeleteCount' => 0,
		'CacheTagInvalidationCount' => 0,
		'CacheTagLookupQueryCount' => 19,
		'CacheTagLookupQueryCount' => 18,
		'ScriptCount' => 1,
		'ScriptBytes' => 12000,
		'StylesheetCount' => 2,