Prevent notice in entity_metadata_no_hook_node_access() when node is not saved

Duplicate? https://drupal.org/node/1780646

No, not duplicate of #1780646: entity_access() fails to check node type specific create access

The access() method of the wrapper accepts only 'view' or 'edit'. However, if the node isn't saved yet, we should check for 'create' in entity_metadata_no_hook_node_access()

This is required to make use of the wonderful Restful module; any idea what needs to happen for it to be added?

This is working properly.

+++ b/modules/callbacks.inc
@@ -669,6 +669,11 @@ function entity_metadata_field_file_validate_item($items, $context) {
+  if ($op == 'update' && !empty($node) && empty($node->nid)) {
+    // In case checking with the wrapper $wrapper->access('edit'), we need to
+    // convert this to create.
+    $op = 'create';

If the wrapper calls the function wrong, it should be fixed in the wrapper instead. It's not the job of this callback to take care of wrong API usage.

I will try to run RESTful tests with this one

It seems that tests are currently failing due to testbot issues:

PHP Fatal error:  Cannot redeclare system_requirements() (previously declared in /var/lib/drupaltestbot/sites/default/files/checkout/modules/system/system.install:11) in /var/lib/drupaltestbot/sites/default/files/checkout/sites/default/modules/rebuild/tests/fixtures/drupal_sites/dev/modules/system/system.install on line 518

I'm pushing another commit. This one worked on my local machine.

Initial test shows patch #18 is working.

@fago can you please review?

This is working for a few month now on RESTful's simpletests.

Is there anything I can do to help move this forward?

I've tested this patch as well and it works great. +1 for merging in the next available release! Thanks!!

Tested with success, +1 to get this committed!

Sry for letting this lie so long. Parts of the patch confuse me though:

    if (empty($node->vid) && in_array($op, array('create', 'update'))) {
      // This is a new node or the original node.

Why/when would there be no vid when it's the update case? It seems invalid for an update case to have a node without a vid, isn't it? Previously the code here only covered create, why is that changed?

> Sry for letting this lie so long

No worries, I'm doing worth on my issue queues ;)

if (empty($node->vid)

I think (haven't tested) that it's related to comment about // This is a new node or the original node. We'll check it..

Patch #18 works!

I could be need something like this to prevent massive warnings in restful, when I create nodes in POST mode, because for ensure user property access, entity access is called indirectly in 'edit' mode, even when the node is not created yet.

However, I'm agree with @fago, the entity contrib module shouldn't prevent the warnings if there is a bad usage of entity API.

There is something I don't entirely understand, in which real case should be checked entity access in update mode, on a entity which doesn't exists yet? Should not be used 'create' access in that case?

Seems that this patch was already applied but this issue was not updated. Can anyone else confirm this?

Yes, looks like this has been applied.

+1 the patch is applied on 1.8

Is included on the commit of this issue:
#1989444: Views integration for properties of type = duration does not work.