GNU bug report logs - #21227
24.5; tls connections not verified by default

Previous Next

Package: emacs;

Reported by: Glyph <glyph <at> twistedmatrix.com>

Date: Mon, 10 Aug 2015 02:32:01 UTC

Severity: important

Tags: fixed, security

Found in version 24.5

Fixed in version 25.1

Done: Lars Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 21227 in the body.
You can then email your comments to 21227 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#21227; Package emacs. (Mon, 10 Aug 2015 02:32:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to Glyph <glyph <at> twistedmatrix.com>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Mon, 10 Aug 2015 02:32:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Glyph <glyph <at> twistedmatrix.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 24.5; tls connections not verified by default
Date: Sun, 9 Aug 2015 19:30:57 -0700
In order to have HTTPS connections verified, one must customize the
behavior of tls.el in a highly non-obvious way:

'(tls-checktrust t)
'(tls-program
   (quote
    ("gnutls-cli --x509cafile $A_CERT_BUNDLE -p %p %h")))

leaving the user to determine an appropriate location for
$A_CERT_BUNDLE.

The whole point of TLS is to ensure the authenticity of connections.
Skipping that step is worse than useless - at least if the user *knows*
they're making a plaintext connection they might guess that they don't
have any security.  So Emacs should use a command-line which
authoritatively makes connections correctly, linking against gnutls
itself if necessary.



In GNU Emacs 24.5.1 (x86_64-apple-darwin13.4.0, NS apple-appkit-1265.21)
of 2015-04-10 on builder10-9.porkrind.org
Windowing system distributor `Apple', version 10.3.1348
Configured using:
`configure --with-ns '--enable-locallisppath=/Library/Application
Support/Emacs/${version}/site-lisp:/Library/Application
Support/Emacs/site-lisp''

Important settings:
  locale-coding-system: utf-8-unix

Major mode: Custom

Minor modes in effect:
  ecb-minor-mode: t
  server-mode: t
  global-undo-tree-mode: t
  undo-tree-mode: t
  global-auto-complete-mode: t
  global-quiet-mousewheel-mode: t
  quiet-mousewheel-mode: t
  async-bytecomp-package-mode: t
  shell-dirtrack-mode: t
  global-semanticdb-minor-mode: t
  global-semantic-idle-scheduler-mode: t
  which-function-mode: t
  show-paren-mode: t
  semantic-mode: t
  icomplete-mode: t
  global-auto-revert-mode: t
  electric-pair-mode: t
  delete-selection-mode: t
  tooltip-mode: t
  electric-indent-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  temp-buffer-resize-mode: t
  column-number-mode: t
  line-number-mode: t
  transient-mark-mode: t

Recent messages:
"Beep."
Quit

Making completion list...

Mark set
"Beep."
Quit
Saving file /Users/glyph/.emacs.d/url/cookies...
Wrote /Users/glyph/.emacs.d/url/cookies

Load-path shadows:
None found.

Features:
(shadow sort mail-extr emacsbug sendmail timezone parse-time vc-git
add-log mm-archive message rfc822 mml mml-sec mailabbrev gmm-utils
mailheader mm-decode mm-bodies mm-encode mail-utils network-stream
starttls url-http tls mail-parse rfc2231 rfc2047 rfc2045 ietf-drums
url-gw url-cache url-auth url-handlers ido debug eieio-opt find-func
misearch multi-isearch package-x apropos help-mode winner mule-util
flymake python-patches python json quickhack ecb-layout-defs cus-edit
warnings ecb ecb-symboldef ecb-analyse ecb-compatibility
ecb-winman-support ecb-autogen autoload lisp-mnt ecb-tod ecb-cycle
ecb-eshell ecb-help ecb-jde ecb-method-browser hideshow
ecb-semantic-wrapper ecb-semantic ecb-file-browser ecb-speedbar
ecb-layout ecb-create-layout ecb-compilation ecb-common-browser speedbar
sb-image dframe ecb-navigate ecb-mode-line ecb-face tree-buffer
ecb-upgrade ecb-cedet-wrapper semantic/db-find semantic/db-ref
semantic/analyze semantic/sort semantic/scope semantic/analyze/fcn
wid-edit ecb-util python-docstring server undo-tree diff pelican-mode
rainbow-delimiters disp-table auto-complete-config auto-complete popup
quiet-mousewheel-mode backandforth obb-mode combinator goto-definition
adaptive-wrap helm-C-x-b helm-imenu helm-command helm-elisp helm-eval
edebug eldoc helm-mode helm-cmd-t helm-files rx image-dired dired-x
dired-aux ffap thingatpt helm-buffers helm-elscreen helm-tags
helm-bookmark helm-adaptive helm-info bookmark pp helm-locate helm-help
helm-match-plugin helm-grep helm-regexp helm-plugin grep helm-external
helm-net browse-url xml url url-proxy url-privacy url-expand url-methods
url-history url-cookie url-domsuf url-util url-parse url-vars mailcap
helm-utils dired compile helm easy-mmode helm-source helm-config
helm-easymenu edmacro kmacro async-bytecomp async helm-aliases tramp
tramp-compat auth-source gnus-util mm-util mail-prsvr password-cache
tramp-loaddefs trampver shell pcomplete comint ansi-color ring
format-spec semantic/db-mode semantic/db eieio-base semantic/idle
semantic/format ezimage semantic/tag-ls semantic/find semantic/ctxt
jka-compr vale-theme which-func imenu paren semantic/util-modes
semantic/util semantic semantic/tag semantic/lex semantic/fw eieio
byte-opt bytecomp byte-compile cl-extra cconv eieio-core mode-local
cedet icomplete autorevert filenotify elec-pair delsel cus-start
cus-load info easymenu package epg-config glyph-setup advice help-fns
cl-macs cl cl-loaddefs cl-lib gv time-date tooltip electric uniquify
ediff-hook vc-hooks lisp-float-type mwheel ns-win tool-bar dnd fontset
image regexp-opt fringe tabulated-list newcomment lisp-mode prog-mode
register page menu-bar rfn-eshadow timer select scroll-bar mouse
jit-lock font-lock syntax facemenu font-core frame cham georgian
utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean
japanese hebrew greek romanian slovak czech european ethiopic indian
cyrillic chinese case-table epa-hook jka-cmpr-hook help simple abbrev
minibuffer nadvice loaddefs button faces cus-face macroexp files
text-properties overlay sha1 md5 base64 format env code-pages mule
custom widget hashtable-print-readable backquote make-network-process
cocoa ns multi-tty emacs)

Memory information:
((conses 16 371323 77866)
(symbols 48 42820 0)
(miscs 40 1349 592)
(strings 32 90979 8531)
(string-bytes 1 2908972)
(vectors 16 36096)
(vector-slots 8 658448 37677)
(floats 8 430 918)
(intervals 56 5019 171)
(buffers 960 41))




Severity set to 'important' from 'normal' Request was from Glenn Morris <rgm <at> gnu.org> to control <at> debbugs.gnu.org. (Mon, 10 Aug 2015 15:49:02 GMT) Full text and rfc822 format available.

Added tag(s) security. Request was from Glenn Morris <rgm <at> gnu.org> to control <at> debbugs.gnu.org. (Mon, 10 Aug 2015 15:49:02 GMT) Full text and rfc822 format available.

Added indication that bug 21227 blocks19759 Request was from Glenn Morris <rgm <at> gnu.org> to control <at> debbugs.gnu.org. (Mon, 10 Aug 2015 15:49:03 GMT) Full text and rfc822 format available.

Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#21227; Package emacs. (Mon, 10 Aug 2015 15:54:01 GMT) Full text and rfc822 format available.

Message #14 received at 21227 <at> debbugs.gnu.org (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: Glyph <glyph <at> twistedmatrix.com>
Cc: 21227 <at> debbugs.gnu.org
Subject: Re: bug#21227: 24.5; tls connections not verified by default
Date: Mon, 10 Aug 2015 11:53:44 -0400
Glyph wrote:

> have any security.  So Emacs should use a command-line which
> authoritatively makes connections correctly, linking against gnutls
> itself if necessary.

Emacs can be linked with Gnutls since Emacs 24.1. You have to compile it
that way though. I think this is perhaps part of the reason why a bunch
of bugs related to the old non-builtin TLS support are piling up. Eg
19283, 19284, 20078. IMO these issues really need to be addressed before
the next release.




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#21227; Package emacs. (Tue, 29 Dec 2015 13:48:02 GMT) Full text and rfc822 format available.

Message #17 received at 21227 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Glyph <glyph <at> twistedmatrix.com>
Cc: 21227 <at> debbugs.gnu.org
Subject: Re: bug#21227: 24.5; tls connections not verified by default
Date: Tue, 29 Dec 2015 14:46:57 +0100
Glyph <glyph <at> twistedmatrix.com> writes:

> In order to have HTTPS connections verified, one must customize the
> behavior of tls.el in a highly non-obvious way:
>
> '(tls-checktrust t)
> '(tls-program
>    (quote
>     ("gnutls-cli --x509cafile $A_CERT_BUNDLE -p %p %h")))
>
> leaving the user to determine an appropriate location for
> $A_CERT_BUNDLE.

This has been fixed in Emacs 25.1. 

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no




Added tag(s) fixed. Request was from Lars Ingebrigtsen <larsi <at> gnus.org> to control <at> debbugs.gnu.org. (Tue, 29 Dec 2015 13:48:02 GMT) Full text and rfc822 format available.

bug marked as fixed in version 25.1, send any further explanations to 21227 <at> debbugs.gnu.org and Glyph <glyph <at> twistedmatrix.com> Request was from Lars Ingebrigtsen <larsi <at> gnus.org> to control <at> debbugs.gnu.org. (Tue, 29 Dec 2015 13:48:02 GMT) Full text and rfc822 format available.

Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#21227; Package emacs. (Wed, 30 Dec 2015 11:40:01 GMT) Full text and rfc822 format available.

Message #24 received at 21227 <at> debbugs.gnu.org (full text, mbox):

From: Glyph Lefkowitz <glyph <at> twistedmatrix.com>
To: 21227 <at> debbugs.gnu.org
Subject: Re: bug#21227 acknowledged by developer (control message for bug
 #21227)
Date: Wed, 30 Dec 2015 03:39:32 -0800
I'm curious - has this been fixed by default for both configurations?  i.e. built with gnutls and without?

-glyph





Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#21227; Package emacs. (Wed, 30 Dec 2015 11:45:02 GMT) Full text and rfc822 format available.

Message #27 received at 21227 <at> debbugs.gnu.org (full text, mbox):

From: Lars Magne Ingebrigtsen <larsi <at> gnus.org>
To: Glyph Lefkowitz <glyph <at> twistedmatrix.com>
Cc: 21227 <at> debbugs.gnu.org
Subject: Re: bug#21227: acknowledged by developer (control message for bug
 #21227)
Date: Wed, 30 Dec 2015 12:44:17 +0100
Glyph Lefkowitz <glyph <at> twistedmatrix.com> writes:

> I'm curious - has this been fixed by default for both configurations?
> i.e. built with gnutls and without?

This was a fix for non-GnuTLS builds.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#21227; Package emacs. (Sun, 03 Jan 2016 08:40:01 GMT) Full text and rfc822 format available.

Message #30 received at 21227 <at> debbugs.gnu.org (full text, mbox):

From: Glyph Lefkowitz <glyph <at> twistedmatrix.com>
To: Lars Magne Ingebrigtsen <larsi <at> gnus.org>
Cc: 21227 <at> debbugs.gnu.org
Subject: Re: bug#21227: acknowledged by developer (control message for bug
 #21227)
Date: Sun, 3 Jan 2016 00:39:08 -0800
[Message part 1 (text/plain, inline)]
> On Dec 30, 2015, at 3:44 AM, Lars Magne Ingebrigtsen <larsi <at> gnus.org> wrote:
> 
> This was a fix for non-GnuTLS builds.

Is there a separate bug number for GnuTLS builds by any chance?

-glyph
[Message part 2 (text/html, inline)]

Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#21227; Package emacs. (Sun, 03 Jan 2016 08:44:02 GMT) Full text and rfc822 format available.

Message #33 received at 21227 <at> debbugs.gnu.org (full text, mbox):

From: Lars Magne Ingebrigtsen <larsi <at> gnus.org>
To: Glyph Lefkowitz <glyph <at> twistedmatrix.com>
Cc: 21227 <at> debbugs.gnu.org
Subject: Re: bug#21227: acknowledged by developer (control message for bug
 #21227)
Date: Sun, 03 Jan 2016 09:43:06 +0100
Glyph Lefkowitz <glyph <at> twistedmatrix.com> writes:

>  On Dec 30, 2015, at 3:44 AM, Lars Magne Ingebrigtsen <larsi <at> gnus.org>
>  wrote:
>
>  This was a fix for non-GnuTLS builds.
>
> Is there a separate bug number for GnuTLS builds by any chance?

I don't understand the question.  This was a problem that related to
non-GnuTLS builds.  This problem doesn't exist in GnuTLS builds.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no




bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Sun, 31 Jan 2016 12:24:03 GMT) Full text and rfc822 format available.

This bug report was last modified 9 years and 127 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.