Timeline for answer to Unix shell function for adding directories to PATH by badc0de
Current License: CC BY-SA 4.0
Post Revisions
13 events
| when toggle format | what | by | license | comment | |
|---|---|---|---|---|---|
| Feb 14, 2022 at 8:29 | history | edited | badc0de | CC BY-SA 4.0 |
added 258 characters in body
|
| Feb 12, 2022 at 23:53 | comment | added | Toby Speight | It looks like you have some pretty good suggestions in there - separate functions to append and prepend is certainly more user-friendly and robust than relying on a second argument to switch behaviours, for example. That's something that could be a worthwhile review and good intro to your alternative solution! | |
| Feb 12, 2022 at 23:49 | comment | added | Toby Speight | So it looks like this isn't a review, but is something of an extended comment on a different answer? | |
| Feb 12, 2022 at 23:45 | comment | added | badc0de | @TobySpeight Sorry, should I link the answer in question. Didn't know how to do that. The sentence would be: "@vpns's answer doesn't include the whole function and also has the IFS problem. This working code doesn't use grep and IFS is untouched." | |
| Feb 12, 2022 at 23:32 | review | Low quality posts | |||
| Feb 13, 2022 at 1:17 | |||||
| Feb 12, 2022 at 23:28 | comment | added | Toby Speight | Where is the review of the code in the question? All I see is a different set of functions that achieve something similar. Can you point to a sentence where you make an observation on the code that was presented for review? | |
| Feb 12, 2022 at 23:18 | comment | added | badc0de | @rolfl What makes you think I had a question? I wrote the code to the best of my knowledge but perhaps someone sees something that I don't. Thus the last two sentences. That's all | |
| Feb 12, 2022 at 23:14 | comment | added | badc0de | @TobySpeight did you find any specific issues in the code which made you suggest that the code is not reviewed? I added a reasoning. It is more a continuation of an idea than an alternative solution. | |
| Feb 12, 2022 at 23:10 | history | edited | badc0de | CC BY-SA 4.0 |
added 175 characters in body
|
| Feb 12, 2022 at 15:13 | comment | added | Toby Speight | You have presented an alternative solution, but haven't reviewed the code. Please edit to show what aspects of the question code prompted you to write this version, and in what ways it's an improvement over the original. It may be worth (re-)reading How to Answer. | |
| Feb 11, 2022 at 19:24 | comment | added | rolfl | If you have a new question, please ask it by clicking the Ask Question button. Include a link to this question if it helps provide context. - From Review | |
| Feb 11, 2022 at 19:04 | review | Late answers | |||
| Feb 11, 2022 at 19:24 | |||||
| Feb 11, 2022 at 18:46 | history | answered | badc0de | CC BY-SA 4.0 |