Timeline for answer to Simple Python Logger by Carlo Lobrano
Current License: CC BY-SA 3.0
Post Revisions
5 events
| when toggle format | what | by | license | comment | |
|---|---|---|---|---|---|
| Dec 28, 2017 at 21:57 | vote | accept | moskaut | ||
| Dec 28, 2017 at 17:05 | comment | added | Carlo Lobrano |
@Coal_ could you explain better the first part? I saw from here that datetime.fromtimestamp could raise a OverflowError. What am I missing? Second part, I agree it's harmless in this context, but I consider it something to avoid (for readability, for future changes, etc.) not an error.
|
|
| Dec 28, 2017 at 13:04 | comment | added | Daniel |
The fromtimestamp assignment won't raise an exception. The log variable is only altered in the local scope of createNewLog, so it's mostly harmless (except for hurting readability, perhaps).
|
|
| Dec 28, 2017 at 12:47 | history | edited | Carlo Lobrano | CC BY-SA 3.0 |
Fixed typos
|
| Dec 28, 2017 at 11:29 | history | answered | Carlo Lobrano | CC BY-SA 3.0 |