Return to Answer

Heap.ctor(T[], HeapType) modifies the provided array, and uses it for internal representation! This is a disaster of epic proportions! You've ruined the user's data, and now they can return the favour by corrupting your heap! Even more fun, because RemoveAt<T>(int) creates a new array (which is an O(n) operation, and exactly something that Heaps are meant to avoid) this behaviour will change when Add is called. You should be using a List<T>, not an array, and you should be creating it yourself, not accepting it from in a constructor.

Heap.ctor(T[], HeapType) modifies the provided array, and uses it for internal representation! This is a disaster of epic proportions! You've ruined the user's data, and now they can return the favour by corrupting your heap! Even more fun, because RemoveAt<T>(int) creates a new array (which is an \$O(n)\$ operation, and exactly something that Heaps are meant to avoid) this behaviour will change when Add is called. You should be using a List<T>, not an array, and you should be creating it yourself, not accepting it from in a constructor.

Again, been a while since I had to understand Binary Heaps, so I couldn't say if this is right or not (cursory testing suggests it works), but it is not O(n), this is O(n*log(n)).

Again, been a while since I had to understand Binary Heaps, so I couldn't say if this is right or not (cursory testing suggests it works), but it is not O(n), this is O(n*log(n)) it is O(n), my memory of algorithms betrays me again.

• Do as Snowbody says, and encapsulate your own representation: don't expose this to anyone.

• Make that representation a List<T>, and call List<T>.Add(T) to add to it, and List<T>.RemoveAt(int) to remove from it.

• Add a Count member to the IHeap<T> interface

• Fix Add

• TEST THE CODE

• Do as Snowbody says, and encapsulate your own representation: don't expose this to anyone.

• Make that representation a List<T>, and call List<T>.Add(T) to add to it, and List<T>.RemoveAt(int) to remove from it.

• Add a Count member to the IHeap<T> interface

• Fix Add

• More comprehensive argument checks, and leave them in the release build

• TEST THE CODE