code review 11803043: syscall: prlimit argument error for Getrlimit and Setrl...

src/pkg/syscall/rlimit_linux_test.go

+// Copyright 2013 The Go Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style
+// license that can be found in the LICENSE file.
+
+package syscall_test
+
+import (
+        "syscall"
+        "testing"
+)
+
+func TestRlimit(t *testing.T) {
+        var rlimit, zero syscall.Rlimit
+        err := syscall.Getrlimit(syscall.RLIMIT_NOFILE, &rlimit)
+        if err != nil {
+                t.Fatalf("Getrlimit: save failed: %v", err)
+        }
+        if zero == rlimit {
+                t.Fatalf("Getrlimit: save failed: got zero value %#v", rlimit)
+                return

[mikio, 2013/07/25 09:59:18]

you can drop return just after t.Fatalf

[peterGo, 2013/07/25 11:42:29]

Done.

+        }
+        set := rlimit
+        set.Cur = set.Max - 1
+        err = syscall.Setrlimit(syscall.RLIMIT_NOFILE, &set)
+        if err != nil {
+                t.Fatalf("Setrlimit: set failed: %#v %v", set, err)
+        }
+        var get syscall.Rlimit
+        err = syscall.Getrlimit(syscall.RLIMIT_NOFILE, &get)
+        if err != nil {
+                t.Fatalf("Getrlimit: get failed: %v", err)
+        }
+        set = rlimit
+        set.Cur = set.Max - 1
+        if set != get {
+                t.Fatalf("Rlimit: change failed: wanted %#v got %#v", set, get)
+                return

[mikio, 2013/07/25 09:59:18]

ditto

[peterGo, 2013/07/25 11:42:29]

Done.

+        }
+        err = syscall.Setrlimit(syscall.RLIMIT_NOFILE, &rlimit)
+        if err != nil {
+                t.Fatalf("Setrlimit: restore failed: %#v %v", rlimit, err)
+        }
+}