code review 11803043: syscall: prlimit argument error for Getrlimit and Setrl...

src/pkg/syscall/syscall_linux_32_test.go

+// Copyright 2013 The Go Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style
+// license that can be found in the LICENSE file.
+
+// +build linux
+// +build 386 arm

[iant, 2013/07/25 04:21:42]

Why not run the test on every linux platform?

If you name the file rlimit_linux_test.go you won't need to use any +build tags.

[peterGo, 2013/07/25 06:50:28]

Done.

+
+package syscall_test
+
+import (
+        "syscall"
+        "testing"
+)
+
+func TestRlimit(t *testing.T) {
+        var rlimit, zeroRlimit syscall.Rlimit

[iant, 2013/07/25 04:21:42]

s/zeroRlimit/zero/

[peterGo, 2013/07/25 06:50:28]

Done.

+        err := syscall.Getrlimit(syscall.RLIMIT_NOFILE, &rlimit)
+        if err != nil {
+                t.Fatalf("Getrlimit: save failed: %v", err)
+        }
+        if zeroRlimit == rlimit {
+                t.Fatalf("Getrlimit: save failed: got zero value %#v", rlimit)
+                return
+        }
+        setRlimit := rlimit

[iant, 2013/07/25 04:21:42]

s/setRlimit/set/

[peterGo, 2013/07/25 06:50:28]

Done.

+        setRlimit.Cur = setRlimit.Max - 1
+        err = syscall.Setrlimit(syscall.RLIMIT_NOFILE, &setRlimit)
+        if err != nil {
+                t.Fatalf("Setrlimit: set failed: %#v %v", setRlimit, err)
+        }
+        var getRlimit syscall.Rlimit

[iant, 2013/07/25 04:21:42]

s/getRlimit/get/

[peterGo, 2013/07/25 06:50:28]

Done.

+        err = syscall.Getrlimit(syscall.RLIMIT_NOFILE, &getRlimit)
+        if err != nil {
+                t.Fatalf("Getrlimit: get failed: %v", err)
+        }
+        setRlimit = rlimit
+        setRlimit.Cur = setRlimit.Max - 1
+        if setRlimit != getRlimit {
+                t.Fatalf("Rlimit: change failed: wanted %#v got %#v", setRlimit, getRlimit)
+                return
+        }
+        err = syscall.Setrlimit(syscall.RLIMIT_NOFILE, &rlimit)
+        if err != nil {
+                t.Fatalf("Setrlimit: restore failed: %#v %v", rlimit, err)
+        }
+}