commit 9055528ba4ff29ba57acc7faa356a90182ed0ae9
author Rakina Zata Amni <rakina@chromium.org> Fri Jan 21 07:35:54 2022
committer Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> Fri Jan 21 07:35:54 2022
tree d0de0d8dd252130e864cc03667fa68afa889a5d6
parent be5f7c234aadd174a4817d4b8768d53076d04fc1

Remove initial empty document-ness when inserting entries from another NavigationController

It's possible to move session history entries to another
NavigationController for DomDistiller etc. Because the new
NavigationController has a fresh FrameTree root, it's still marked as
"on the initial empty document" that would automatically cause a
session history replacement in the next navigation. We don't want that
behavior (e.g. DomDistiller wants to be able to return to the copied
last committed entry).

If the source NavigationController is no longer on the initial empty
document, make sure the the target NavigationController is also marked
as no longer being on the initial empty document, so that the next
navigation there won't try to do an initial empty document replacement.
The test NavigationControllerTest.CopyStateFrom is modified to assert
that the "initial empty document" is gone, and a DomDistiller test will
be added later

Bug: 1284566
Change-Id: Ic741fc18412dc349814c8721aa08b9fbe4a398ec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3397899
Reviewed-by: Fergal Daly <fergal@chromium.org>
Commit-Queue: Rakina Zata Amni <rakina@chromium.org>
Cr-Commit-Position: refs/heads/main@{#961814}