commit 76098e5105773b87630a4ec45d6127e756fe8940
author arthursonzogni <arthursonzogni@chromium.org> Wed Nov 25 14:18:45 2020
committer Commit Bot <commit-bot@chromium.org> Wed Nov 25 14:18:45 2020
tree 856bdc83ab871798ca4de2913657bdbf3fe533ff
parent 738760ae68d87899813483de36f851dda461a006

Remove the DidSetFramePolicyHeaders IPC.

Merge the DidSetFramePolicyHeaders IPC into DidCommitProvisionalLoad.
They were sent together one after the other, but in two separate calls,
which caused race conditions.

Benefits:

1. Fix a race condition about sandbox flags. This is
   https://bugs.chromium.org/p/chromium/issues/detail?id=1145139#c5.
   The first IPC was resetting the sandbox flags, and the second was
   updating them with the right values. If a navigation is started from
   the browser process just in between receiving both IPCs, the
   navigation will use no sandbox, when it should have.

2. Fix https://crbug.com/1093268. It was possible to receive
   DidSetFramePolicyHeaders for speculative RenderFrameHost. It is
   logically no more possible, since DidCommitProvisionalLoad is the IPC
   that will "activate" the speculative RenderFrameHost.

3. Recover from https://crbug.com/1146025. Page with sandbox flags are
   properly restored after entering the BackForwardCache.

4. Since the IPC doesn't exist anymore. There are no more need to be
   guarded behind a `IsInactiveAndDisallowReactivation`. A page in the
   backforward cache can't receive this anymore, since it doesn't exist.

Fixed: 1145139, 1146025
Bug: 1145139, 1146025
Change-Id: Ic720dd125a103fa09894a7f5348accc34823e33b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536467
Reviewed-by: Andy Paicu <andypaicu@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Reviewed-by: Ian Clelland <iclelland@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#830989}