Google Git
Sign in
chromium / chromium / src / f42a7d01847cd88af53bc11f2f0f0dc0e9c51616
commitf42a7d01847cd88af53bc11f2f0f0dc0e9c51616[log] [tgz]
authorAkihiro Ota <akihiroota@chromium.org>Fri Jun 12 19:07:56 2020
committerCommit Bot <commit-bot@chromium.org>Fri Jun 12 19:07:56 2020
tree282f93fdb0cb5f01f4c1b43fb1e49da5b34e3b11
parent977c039978855e0c06d2f59fcfd3b621cc171e63 [diff]
PosInSet and SetSize Cleanup.

1. Moves all logic into AXTree, instead of splitting logic with AXNode.
This allows us to check the cache before doing anything else, which
eliminates some redundant work we were doing before.
2. Add a new AXTreeTest for hidden nodes.
3. Change null return value from 0 to base::nullopt. This more
accurately reflects that we were unable to compute a valid value for
either posinset or setsize.
4. Update expectation files.

Bug: N/A
AX-Relnotes: N/A
Change-Id: I5b0bc2c40f6adfc97f3bca2426dcca55ef4dba62
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2204427
Commit-Queue: Akihiro Ota <akihiroota@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#777903}
16 files changed
tree: 282f93fdb0cb5f01f4c1b43fb1e49da5b34e3b11
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. jingle/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. weblayer/
  52. .clang-format
  53. .clang-tidy
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitattributes
  57. .gitignore
  58. .gn
  59. .vpython
  60. .vpython3
  61. .yapfignore
  62. AUTHORS
  63. BUILD.gn
  64. CODE_OF_CONDUCT.md
  65. codereview.settings
  66. DEPS
  67. ENG_REVIEW_OWNERS
  68. LICENSE
  69. LICENSE.chromium_os
  70. OWNERS
  71. PRESUBMIT.py
  72. PRESUBMIT_test.py
  73. PRESUBMIT_test_mocks.py
  74. README.md
  75. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.