Google Git
Sign in
chromium / chromium / src / 60e47131b1713f1dca79d3b858578a3ad126614e
commit60e47131b1713f1dca79d3b858578a3ad126614e[log] [tgz]
authorSreeja Kamishetty <sreejakshetty@chromium.org>Tue Feb 08 12:51:53 2022
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Tue Feb 08 12:51:53 2022
tree716ba7dfa81f4d4ecf57364be899ba4e3c891dbd
parente8146addf7021b09ccb3573ee152a5105e86057b [diff]
Rename and Move RFHI::InsidePortal() to FrameTree::IsPortal()

Current naming of RenderFrameHostImpl::InsidePortal() is confusing
considering various cases like fenced frame embedded inside a portal.
Also InsidePortal() API checks for IsPortal() value.

To avoid this confusion, we want to rename it back to IsPortal and
looking at the usecases of InsidePortal, it would be more apt to have
it inside FrameTree to avoid FTN -> RFH usages.

We also double check that a fenced frame when embedded inside a portal
FrameTree::IsPortal() returns false.

BUG=1294795,1179502

Change-Id: I628659265cd1c5acba31386cc0ebe2d9b89b8157
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3424548
Reviewed-by: Kevin McNee <mcnee@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Commit-Queue: Sreeja Kamishetty <sreejakshetty@chromium.org>
Cr-Commit-Position: refs/heads/main@{#968287}
8 files changed
tree: 716ba7dfa81f4d4ecf57364be899ba4e3c891dbd
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. codelabs/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. weblayer/
  52. .clang-format
  53. .clang-tidy
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitattributes
  57. .gitignore
  58. .gn
  59. .mailmap
  60. .rustfmt.toml
  61. .vpython
  62. .vpython3
  63. .yapfignore
  64. AUTHORS
  65. BUILD.gn
  66. CODE_OF_CONDUCT.md
  67. codereview.settings
  68. DEPS
  69. DIR_METADATA
  70. ENG_REVIEW_OWNERS
  71. LICENSE
  72. LICENSE.chromium_os
  73. OWNERS
  74. PRESUBMIT.py
  75. PRESUBMIT_test.py
  76. PRESUBMIT_test_mocks.py
  77. README.md
  78. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.