Google Git
Sign in
chromium / chromium / src / 272975a442651d7b2caec732006435f03ef1548c
commit272975a442651d7b2caec732006435f03ef1548c[log] [tgz]
authorHenrique Ferreiro <hferreiro@igalia.com>Mon Jan 24 10:14:55 2022
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Mon Jan 24 10:14:55 2022
tree63f189450f909a1efa8aebeb271608fb14c738b9
parent5a45dd09209427be0f67e97c22706f794880f0bc [diff]
Remove MediaFactory dependency on WebMediaPlayerImpl

In this CL, WebMediaPlayerImpl is built indirectly via a builder
function that just passes the constructor parameters removing a direct
dependency from MediaFactory. This allows to move WebMediaPlayerImpl out
of the Blink public API with the following benefits:
* WebMediaPlayerImpl has some Mojo class members which can now be
  changed to use the Blink-variant Mojo types.
* Some dependencies of WebMediaPlayerImpl can be moved out of
  public/platform/media/ as they aren't used elsewhere.

web_media_player_impl.h is still including '*.mojom.h' files so we need
to disable the presubmit checks. Porting it to Blink would require many
more changes and will be done in future CLs.

No-Presubmit: true
Bug: 1198318
Change-Id: I1f5fbec5e463cb902596d57c81c48eae72d76b8b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3361040
Reviewed-by: Will Cassella <cassew@chromium.org>
Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com>
Cr-Commit-Position: refs/heads/main@{#962416}
12 files changed
tree: 63f189450f909a1efa8aebeb271608fb14c738b9
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. codelabs/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. jingle/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. weblayer/
  53. .clang-format
  54. .clang-tidy
  55. .eslintrc.js
  56. .git-blame-ignore-revs
  57. .gitattributes
  58. .gitignore
  59. .gn
  60. .mailmap
  61. .rustfmt.toml
  62. .vpython
  63. .vpython3
  64. .yapfignore
  65. AUTHORS
  66. BUILD.gn
  67. CODE_OF_CONDUCT.md
  68. codereview.settings
  69. DEPS
  70. DIR_METADATA
  71. ENG_REVIEW_OWNERS
  72. LICENSE
  73. LICENSE.chromium_os
  74. OWNERS
  75. PRESUBMIT.py
  76. PRESUBMIT_test.py
  77. PRESUBMIT_test_mocks.py
  78. README.md
  79. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.