commit 2322f4f88b7932a864a916bebf7b26214d0461ba
author Rakina Zata Amni <rakina@chromium.org> Mon Jan 24 13:24:24 2022
committer Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> Mon Jan 24 13:24:24 2022
tree 0b7c3fa52b3b6a7b124ac456d850eb6879ab86b1
parent d088d3205199fc80e443f38cdf3e20e8b28da987

Protect initial NavigationEntry creation behind a flag

Adds the InitialNavigationEntry flag, which controls whether we create
the initial NavigationEntry on FrameTree creation or not. It's enabled
by default, keeping the behavior from before this CL but gives a
kill switch in case there are unexpected web-exposed changes, which
had happened with WebView previously (see linked bug). We intend to
merge this to M98.

To make sure the code supports both configuration (creating initial
NavigationEntry vs not), this CL returns all the entry null-checks and
other boundary checks etc removed by the initial NavigationEntry CLs,
and also parts of the code that is needed to support the legacy path,
mostly referring to the reverted version (see crrev.com/c/3396405 for
the revert CL). All tests are updated to accommodate both paths (except
Android tests, not sure how to check flags from there).

See crrev.com/c/3398328 for CQ runs and Android test modifications
needed with the flag disabled.

Bug: 524208, 1277414
Change-Id: I6b39e52ea3f83b066ccdd9fee9f5cf979097d2c1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3398082
Reviewed-by: Charles Reis <creis@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Reviewed-by: Olesia Marukhno <olesiamarukhno@google.com>
Reviewed-by: Clark DuVall <cduvall@chromium.org>
Reviewed-by: Chris Thompson <cthomp@chromium.org>
Reviewed-by: Devlin Cronin <rdevlin.cronin@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Reviewed-by: Nate Chapin <japhet@chromium.org>
Reviewed-by: Daniel Rubery <drubery@chromium.org>
Reviewed-by: Nate Fischer <ntfschr@chromium.org>
Reviewed-by: David Roger <droger@chromium.org>
Commit-Queue: Rakina Zata Amni <rakina@chromium.org>
Cr-Commit-Position: refs/heads/main@{#962457}