Report forwarded
to debian-bugs-dist@lists.debian.org, md@linux.it, LaMont Jones <lamont@debian.org>: Bug#889668; Package util-linux.
(Mon, 05 Feb 2018 14:39:04 GMT) (full text, mbox, link).
Acknowledgement sent
to Marco d'Itri <md@linux.it>:
New Bug report received and forwarded. Copy sent to md@linux.it, LaMont Jones <lamont@debian.org>.
(Mon, 05 Feb 2018 14:39:04 GMT) (full text, mbox, link).
Package: util-linux
Version: 2.30.2-0.3
Severity: normal
Please install /usr/share/doc/util-linux/examples/fstrim.timer as
/usr/lib/systemd/system/fstrim.timer instead.
There is no need to enable it by default, but please install the file so
it will be available for users who want to enable it.
--
ciao,
Marco
Information forwarded
to debian-bugs-dist@lists.debian.org, LaMont Jones <lamont@debian.org>: Bug#889668; Package util-linux.
(Tue, 13 Feb 2018 11:27:03 GMT) (full text, mbox, link).
Acknowledgement sent
to Laurent Bigonville <bigon@debian.org>:
Extra info received and forwarded to list. Copy sent to LaMont Jones <lamont@debian.org>.
(Tue, 13 Feb 2018 11:27:03 GMT) (full text, mbox, link).
Subject: util-linux: diff for NMU version 2.31.1-0.2
Date: Tue, 13 Feb 2018 12:25:21 +0100
Control: tags 889668 + patch
Control: tags 889668 + pending
Dear maintainer,
I've prepared an NMU for util-linux (versioned as 2.31.1-0.2) and
uploaded it to DELAYED/3. Please feel free to tell me if I
should delay it longer.
Regards.
diff -Nru util-linux-2.31.1/debian/changelog util-linux-2.31.1/debian/changelog
--- util-linux-2.31.1/debian/changelog 2018-02-09 19:16:51.000000000 +0100
+++ util-linux-2.31.1/debian/changelog 2018-02-13 12:19:06.000000000 +0100
@@ -1,3 +1,11 @@
+util-linux (2.31.1-0.2) unstable; urgency=medium
+
+ * Non-maintainer upload.
+ * Install fstrim.timer and fstrim.service without enabling it by default
+ (for now), see discussion in #732054 (Closes: #889668)
+
+ -- Laurent Bigonville <bigon@debian.org> Tue, 13 Feb 2018 12:19:06 +0100
+
util-linux (2.31.1-0.1) unstable; urgency=medium
* Non-maintainer upload.
diff -Nru util-linux-2.31.1/debian/rules util-linux-2.31.1/debian/rules
--- util-linux-2.31.1/debian/rules 2018-02-09 19:16:51.000000000 +0100
+++ util-linux-2.31.1/debian/rules 2018-02-13 11:45:16.000000000 +0100
@@ -157,6 +157,10 @@
override_dh_fixperms:
dh_fixperms -i -a -Xusr/bin/wall -Xbin/mount -Xbin/umount
+override_dh_installsystemd:
+ dh_installsystemd -putil-linux --no-enable --no-start fstrim.timer fstrim.service
+ dh_installsystemd --remaining-packages
+
override_dh_auto_test:
ifeq ($(DEB_HOST_ARCH_OS), linux)
dh_auto_test --max-parallel=1
diff -Nru util-linux-2.31.1/debian/util-linux.install util-linux-2.31.1/debian/util-linux.install
--- util-linux-2.31.1/debian/util-linux.install 2018-02-09 19:16:51.000000000 +0100
+++ util-linux-2.31.1/debian/util-linux.install 2018-02-12 18:03:47.000000000 +0100
@@ -7,8 +7,8 @@
[linux-any] sbin/mkswap
[!linux-any] debian/tmp/sbin/mkswap => /sbin/mkswap.linux
# weekly fstrim only available on linux
-[linux-any] lib/systemd/system/fstrim.timer => /usr/share/doc/util-linux/examples/fstrim.timer
-[linux-any] lib/systemd/system/fstrim.service => /usr/share/doc/util-linux/examples/fstrim.service
+[linux-any] lib/systemd/system/fstrim.timer
+[linux-any] lib/systemd/system/fstrim.service
bin/findmnt
bin/more
bin/mountpoint
Added tag(s) patch.
Request was from Laurent Bigonville <bigon@debian.org>
to 889668-submit@bugs.debian.org.
(Tue, 13 Feb 2018 11:27:03 GMT) (full text, mbox, link).
Added tag(s) pending.
Request was from Laurent Bigonville <bigon@debian.org>
to 889668-submit@bugs.debian.org.
(Tue, 13 Feb 2018 11:27:04 GMT) (full text, mbox, link).
Information forwarded
to debian-bugs-dist@lists.debian.org, LaMont Jones <lamont@debian.org>: Bug#889668; Package util-linux.
(Tue, 13 Feb 2018 19:12:04 GMT) (full text, mbox, link).
Acknowledgement sent
to Laurent Bigonville <bigon@debian.org>:
Extra info received and forwarded to list. Copy sent to LaMont Jones <lamont@debian.org>.
(Tue, 13 Feb 2018 19:12:04 GMT) (full text, mbox, link).
Subject: Bug#889668: fixed in util-linux 2.31.1-0.3
Date: Wed, 14 Feb 2018 09:56:25 +0000
Source: util-linux
Source-Version: 2.31.1-0.3
We believe that the bug you reported is fixed in the latest version of
util-linux, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to 889668@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Laurent Bigonville <bigon@debian.org> (supplier of updated util-linux package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
Format: 1.8
Date: Wed, 14 Feb 2018 10:32:51 +0100
Source: util-linux
Binary: util-linux util-linux-locales mount bsdutils fdisk fdisk-udeb libblkid1 libblkid1-udeb libblkid-dev libfdisk1 libfdisk1-udeb libfdisk-dev libmount1 libmount1-udeb libmount-dev libsmartcols1 libsmartcols1-udeb libsmartcols-dev libuuid1 uuid-runtime libuuid1-udeb uuid-dev util-linux-udeb setpriv rfkill
Architecture: source
Version: 2.31.1-0.3
Distribution: unstable
Urgency: medium
Maintainer: LaMont Jones <lamont@debian.org>
Changed-By: Laurent Bigonville <bigon@debian.org>
Description:
bsdutils - basic utilities from 4.4BSD-Lite
fdisk - collection of partitioning utilities
fdisk-udeb - Manually partition a hard drive (fdisk) (udeb)
libblkid-dev - block device ID library - headers and static libraries
libblkid1 - block device ID library
libblkid1-udeb - stripped down block device ID library, for debian-installer (udeb)
libfdisk-dev - fdisk partitioning library - headers and static libraries
libfdisk1 - fdisk partitioning library
libfdisk1-udeb - stripped down fdisk partitioning library, for debian-installer (udeb)
libmount-dev - device mounting library - headers and static libraries
libmount1 - device mounting library
libmount1-udeb - stripped down device mounting library, for debian-installer (udeb)
libsmartcols-dev - smart column output alignment library - headers and static librar
libsmartcols1 - smart column output alignment library
libsmartcols1-udeb - stripped down smart column output aligment library, for debian-in (udeb)
libuuid1 - Universally Unique ID library
libuuid1-udeb - stripped down Universally Unique ID library, for debian-installer (udeb)
mount - tools for mounting and manipulating filesystems
rfkill - tool for enabling and disabling wireless devices
setpriv - tool to run a program with different Linux privilege settings
util-linux - miscellaneous system utilities
util-linux-locales - locales files for util-linux
util-linux-udeb - stripped down miscellaneous system utilities, for debian-installe (udeb)
uuid-dev - Universally Unique ID library - headers and static libraries
uuid-runtime - runtime components for the Universally Unique ID library
Closes: 889668
Changes:
util-linux (2.31.1-0.3) unstable; urgency=medium
.
* Non-maintainer upload.
* Install fstrim.timer and fstrim.service without enabling it by default
(for now), see discussion in #732054 (Closes: #889668)
Checksums-Sha1:
c426d0af7855812ca76c72ad46aec3192d7f57ce 3669 util-linux_2.31.1-0.3.dsc
2c7514e4c844bf3d8faf18b1db1bb3199d46c816 82628 util-linux_2.31.1-0.3.debian.tar.xz
11025a0550fa7c5c32cd23f1210e66b7cc6e5195 6389 util-linux_2.31.1-0.3_source.buildinfo
Checksums-Sha256:
57bb939b492436c1ed37379930626370563cce3954fa0fd2a9a4b8443d2ef9af 3669 util-linux_2.31.1-0.3.dsc
8446b637ce51f469c2373b0d7974ceb04f682388e50ad90e2af8307ceab6d94c 82628 util-linux_2.31.1-0.3.debian.tar.xz
709c0fd519a5c34289353e0b03ac9ca5814da1df14edc7c2221fcdcf1951df91 6389 util-linux_2.31.1-0.3_source.buildinfo
Files:
cd85a730878b62d1ae40fa7187d85a7b 3669 base required util-linux_2.31.1-0.3.dsc
27ea98113a1a0fefb694afaa4eddce77 82628 base required util-linux_2.31.1-0.3.debian.tar.xz
46bc4be40cb0b394aa13525381bb7807 6389 base required util-linux_2.31.1-0.3_source.buildinfo
-----BEGIN PGP SIGNATURE-----
iQFFBAEBCAAvFiEEmRrdqQAhuF2x31DwH8WJHrqwQ9UFAlqEA28RHGJpZ29uQGRl
Ymlhbi5vcmcACgkQH8WJHrqwQ9Wyywf/WmSQuX72CB03N/1lMtjv9RqPS//aXPE3
4vS86oTXW8KvoT9EOoTSjVMhrOgLldY9nF10KREo/qvRfxpNyFhQmTHeq/DRa7IZ
DnxYsEMpfCR46fw07/ThBt7YSpdloQozDBcB2HngTJLyNaIJ/UzZqL+80RQ/u8Rm
2kSwo9xwIHFprDM2hD18gk5ChQo6nQlY7pF+WczERUiVcHjkw4wu2V0guhd/mnZU
SyUYqs8MKoPYcbz1JMiHH/FokuRDjkQqpGuKQtk4f/Y7YyTXpV1LmixbL3x/4hip
9vw5j2Dbg3YLVuPFYVmkhpzahzOVc/3t0Jnnuzav02JlwzPBzttbvA==
=o6OF
-----END PGP SIGNATURE-----
Information forwarded
to debian-bugs-dist@lists.debian.org, dcruncher1@gmail.com, LaMont Jones <lamont@debian.org>: Bug#889668; Package util-linux.
(Mon, 05 Mar 2018 00:33:04 GMT) (full text, mbox, link).
Acknowledgement sent
to cruncher <dcruncher1@gmail.com>:
Extra info received and forwarded to list. Copy sent to dcruncher1@gmail.com, LaMont Jones <lamont@debian.org>.
(Mon, 05 Mar 2018 00:33:04 GMT) (full text, mbox, link).
Package: util-linux
Version: 2.31.1-0.4
Followup-For: Bug #889668
Hi
Goal: Not running fstrim automatically
I have no idea how this is normally handled, but the fstrim.timer/service
should NOT be enabled by default (or at least use maybe /etc/default/fstrim to
have the setting unchanged after every update).
Right now i have to manually disable it after each update on every machine as
it is unneeded or even unwanted on some/most machines (useless on encrypted
ssds, even "harming" for the ssd and security).
Therefore it would be nice if we could have i.e. a settings file
like "/etc/default/fstrim" where we can set & let the settings there
permanently, or have a separate fstrim package (when package is installed
fstrim runs weekly, if not installed nothing happens).
Regards
-- System Information:
Debian Release: buster/sid
APT prefers unstable
APT policy: (500, 'unstable')
Architecture: amd64 (x86_64)
Foreign Architectures: i386
Kernel: Linux 4.15.0-1-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_US.utf8, LC_CTYPE=en_US.utf8 (charmap=UTF-8), LANGUAGE=en_US:en (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled
Versions of packages util-linux depends on:
ii fdisk 2.31.1-0.4
ii libblkid1 2.31.1-0.4
ii libc6 2.27-1
ii libmount1 2.31.1-0.4
ii libpam0g 1.1.8-3.7
ii libselinux1 2.7-2+b1
ii libsmartcols1 2.31.1-0.4
ii libsystemd0 237-4
ii libtinfo5 6.1-1
ii libudev1 237-4
ii libuuid1 2.31.1-0.4
ii zlib1g 1:1.2.8.dfsg-5
util-linux recommends no packages.
Versions of packages util-linux suggests:
ii dosfstools 4.1-1
ii kbd 2.0.4-2
ii util-linux-locales 2.31.1-0.4
-- no debconf information
Information forwarded
to debian-bugs-dist@lists.debian.org, LaMont Jones <lamont@debian.org>: Bug#889668; Package util-linux.
(Fri, 16 Mar 2018 03:06:03 GMT) (full text, mbox, link).
Acknowledgement sent
to Christoph Anton Mitterer <calestyo@scientia.net>:
Extra info received and forwarded to list. Copy sent to LaMont Jones <lamont@debian.org>.
(Fri, 16 Mar 2018 03:06:03 GMT) (full text, mbox, link).
Hey.
Just adding my 2 cents on this.
As cruncher already noted, TRIM/discard may have an influence on the
security of encrypted devices.
But... per default, dm-crypt (respectively cryptsetup) sets the devices
to ignore any trim commands and not pass it down to lower layers (
--allow-discards option).
However, even apart from that I think this should never be enabled by
default:
- If a fs properly supports discard, it will anyway has its own mount
options for controlling it an there should be no need to call fstrim
- Calling trim typically means the data is gone (or at least not easily
accessible anymore)... while this is intended of of course, it may have
disadvantages e.g. in case of fs corruption, non-discarded areas could
still be recovered (even if it may be some tough work).
Also, calling fstrim for *any* filesystem per default is IMO a bad
thing. Users may have e.g. external HDDs connected (which shouldn't be
trimmed, maybe because they're very large) or filesystems mounted for
which recovery or forensic analysis is to be done.
Cheers,
Chris.
No longer marked as found in versions util-linux/2.31.1-0.4.
Request was from Andreas Beckmann <anbe@debian.org>
to control@bugs.debian.org.
(Thu, 12 Jul 2018 13:48:05 GMT) (full text, mbox, link).
Information forwarded
to debian-bugs-dist@lists.debian.org, LaMont Jones <lamont@debian.org>: Bug#889668; Package util-linux.
(Tue, 31 Jul 2018 07:33:07 GMT) (full text, mbox, link).
Acknowledgement sent
to Philipp Kern <pkern@debian.org>:
Extra info received and forwarded to list. Copy sent to LaMont Jones <lamont@debian.org>.
(Tue, 31 Jul 2018 07:33:07 GMT) (full text, mbox, link).
On 16.03.2018 03:58, Christoph Anton Mitterer wrote:
> As cruncher already noted, TRIM/discard may have an influence on the
> security of encrypted devices.
> But... per default, dm-crypt (respectively cryptsetup) sets the devices
> to ignore any trim commands and not pass it down to lower layers (
> --allow-discards option).
debian-installer will now default to enable discard on crypto block
devices upon creation.
> However, even apart from that I think this should never be enabled by
> default:
> - If a fs properly supports discard, it will anyway has its own mount
> options for controlling it an there should be no need to call fstrim
As we know running with continuous TRIM enabled is very bad for some
SSDs and so a very poor default. fstrim has the advantage that it
batches all TRIM requests into large areas and issues them at once.
There are still enough SSDs that stall I/O if you insert TRIM requests
into the write request path. Hence it's almost never enabled by default
within a file system and you need an external helper such as fstrim to
be enabled.
> - Calling trim typically means the data is gone (or at least not easily
> accessible anymore)... while this is intended of of course, it may have
> disadvantages e.g. in case of fs corruption, non-discarded areas could
> still be recovered (even if it may be some tough work).
> Also, calling fstrim for *any* filesystem per default is IMO a bad
> thing. Users may have e.g. external HDDs connected (which shouldn't be
> trimmed, maybe because they're very large) or filesystems mounted for
> which recovery or forensic analysis is to be done.
I buy the argument for attached removable file systems. It looks like
today fstrim iterates over /proc/self/mountinfo and trims all
non-pseudo/non-netfs. On the other hand enough guides on the internet
say that to have a working system with an SSD, you want to have TRIM. By
not applying the proper defaults, many users will still enable
fstrim.timer and then not think about it when the recovery/forensic case
comes along. So this is surprising nonetheless.
It feels like fstrim should have a mode that looks at volumes referenced
by /etc/fstab (just like mount -a, that it wanted to mimic according to
the code) instead of the currently mounted filesystems. And then we
actually should enable that by default.
I think the appropriate protection against a weekly(!) cronjob that
TRIMs your disk are a) backups and b) a filesystem that supports
snapshots and can recover from corruption. Keeping blocks around also
just makes forensics easier. (It's a double-edged sword.)
Kind regards
Philipp Kern
Information forwarded
to debian-bugs-dist@lists.debian.org, LaMont Jones <lamont@debian.org>: Bug#889668; Package util-linux.
(Tue, 31 Jul 2018 08:51:03 GMT) (full text, mbox, link).
Acknowledgement sent
to Philipp Kern <pkern@debian.org>:
Extra info received and forwarded to list. Copy sent to LaMont Jones <lamont@debian.org>.
(Tue, 31 Jul 2018 08:51:03 GMT) (full text, mbox, link).
On 2018-07-31 09:24, Philipp Kern wrote:
> I buy the argument for attached removable file systems. It looks like
> today fstrim iterates over /proc/self/mountinfo and trims all
> non-pseudo/non-netfs. On the other hand enough guides on the internet
> say that to have a working system with an SSD, you want to have TRIM.
> By
> not applying the proper defaults, many users will still enable
> fstrim.timer and then not think about it when the recovery/forensic
> case
> comes along. So this is surprising nonetheless.
>
> It feels like fstrim should have a mode that looks at volumes
> referenced
> by /etc/fstab (just like mount -a, that it wanted to mimic according to
> the code) instead of the currently mounted filesystems. And then we
> actually should enable that by default.
I filed https://github.com/karelzak/util-linux/issues/673 upstream about
this.
Kind regards
Philipp Kern
Information forwarded
to debian-bugs-dist@lists.debian.org, LaMont Jones <lamont@debian.org>: Bug#889668; Package util-linux.
(Tue, 31 Jul 2018 15:15:03 GMT) (full text, mbox, link).
Acknowledgement sent
to Philipp Kern <pkern@debian.org>:
Extra info received and forwarded to list. Copy sent to LaMont Jones <lamont@debian.org>.
(Tue, 31 Jul 2018 15:15:03 GMT) (full text, mbox, link).
On 2018-07-31 10:46, Philipp Kern wrote:
> On 2018-07-31 09:24, Philipp Kern wrote:
>> I buy the argument for attached removable file systems. It looks like
>> today fstrim iterates over /proc/self/mountinfo and trims all
>> non-pseudo/non-netfs. On the other hand enough guides on the internet
>> say that to have a working system with an SSD, you want to have TRIM.
>> By
>> not applying the proper defaults, many users will still enable
>> fstrim.timer and then not think about it when the recovery/forensic
>> case
>> comes along. So this is surprising nonetheless.
>>
>> It feels like fstrim should have a mode that looks at volumes
>> referenced
>> by /etc/fstab (just like mount -a, that it wanted to mimic according
>> to
>> the code) instead of the currently mounted filesystems. And then we
>> actually should enable that by default.
>
> I filed https://github.com/karelzak/util-linux/issues/673 upstream
> about this.
And the amazing util-linux upstream author Karel already fixed it in
https://github.com/karelzak/util-linux/commit/c5b8909f13d29d066ee9882fe0e3129d2f3bcffc
and now provides an -A option that just looks at fstab. I guess I'll go
and file a separate bug once that's in a release to make that enabled by
default.
Kind regards
Philipp Kern
Bug archived.
Request was from Debbugs Internal Request <owner@bugs.debian.org>
to internal_control@bugs.debian.org.
(Wed, 29 Aug 2018 07:29:00 GMT) (full text, mbox, link).
Debbugs is free software and licensed under the terms of the GNU General
Public License version 2. The current version can be obtained
from https://bugs.debian.org/debbugs-source/.
